Hi Joe, On Jul 16, 2013, at 4:14 PM, Joe Darcy wrote:
> I've looked over all the code in BigInteger for general consistency of > braces, spacing, etc. > > Besides the changes you're made, here are additional updates to BigInteger: > > […] Please note that I only reviewed the portions of the code which were touched by the recent contributions, not the entire class. > The texts below should be in standard block comment format. > > 1614 /* The algorithm requires two divisions by 2 and one by 3. > 1615 All divisions are known to be exact, that is, they do not > produce > 1616 remainders, and all results are positive. The divisions by 2 > are > 1617 implemented as right shifts which are relatively efficient, > leaving > 1618 only an exact division by 3, which is done by a specialized > 1619 linear-time algorithm. */ > > 1914 /* The algorithm requires two divisions by 2 and one by 3. > 1915 All divisions are known to be exact, that is, they do not > produce > 1916 remainders, and all results are positive. The divisions by 2 > are > 1917 implemented as right shifts which are relatively efficient, > leaving > 1918 only a division by 3. > 1919 The division by 3 is done by an optimized algorithm for this > case. > 1920 */ This I missed. > Please take an analogous pass over MutableBigInteger. OK Thanks, Brian
