Hi Brian,
This latest version looks good to go; thanks,
-Joe
On 07/16/2013 06:08 PM, Brian Burkhalter wrote:
Hi Joe,
I've updated the webrev http://cr.openjdk.java.net/~bpb/8020641/
<http://cr.openjdk.java.net/%7Ebpb/8020641/> with these last changes.
I am not preparing an hg export patch until 8014319 is approved.
Thanks,
Brian
On Jul 16, 2013, at 5:57 PM, Joe Darcy wrote:
Please reformat the BigInteger comment at
1915 /* The algorithm requires two divisions by 2 and one by 3.
1916 All divisions are known to be exact, that is, they do
not produce
1917 remainders, and all results are positive. The
divisions by 2 are
1918 implemented as right shifts which are relatively
efficient, leaving
1919 only a division by 3.
1920 The division by 3 is done by an optimized algorithm
for this case.
1921 */
In MutableBigInteger
1486 if(Integer.numberOfLeadingZeros(value[offset]) >= shift) {
1539 for(int j=0; j < limit-1; j++) {
1663 if(needRemainder) {
still need an extra space.