Hi Joe,

The changes requested below have been made and the webrev updated accordingly:

http://cr.openjdk.java.net/~bpb/8020539/

The HTML for Scanner may be viewed here

http://cr.openjdk.java.net/~bpb/Scanner.html

Thanks,

Brian

On Jul 16, 2013, at 1:59 PM, Joe Darcy wrote:

> For the changes in j.u.Random,
> 
> -     * pseudorandomly generated and returned. All 2<font size="-1"><sup>32
> +     * pseudorandomly generated and returned. All 2<font 
> style="font-size:smaller;"><sup>32
> 
> I would just dispense with the size adjustment of the exponent -- the 
> <sup></sup> tag alone should be sufficient. Plain <sup></sup> is used in 
> java.lang.Integer and elsewhere in the core libraries.
> 
> For the changes in Scanner, I recommend using definition lists instead. For 
> guidance, here is an example from java.lang.Integer:
> 
>     * <dl>
>     * <dt><i>DecodableString:</i>
>     * <dd><i>Sign<sub>opt</sub> DecimalNumeral</i>
>     * <dd><i>Sign<sub>opt</sub></i> {@code 0x} <i>HexDigits</i>
>     * <dd><i>Sign<sub>opt</sub></i> {@code 0X} <i>HexDigits</i>
>     * <dd><i>Sign<sub>opt</sub></i> {@code #} <i>HexDigits</i>
>     * <dd><i>Sign<sub>opt</sub></i> {@code 0} <i>OctalDigits</i>
>     * <p>
>     * <dt><i>Sign:</i>
>     * <dd>{@code -}
>     * <dd>{@code +}
>     * </dl>
> 
> The other changes look fine.

Reply via email to