On Jul 17, 2013, at 10:07 PM, Joe Darcy wrote:

> In Random.java, I would prefer if the <font> size manipulation of the 
> exponent was removed instead of
> 
> 373      * All 2<fontstyle="font-size:smaller;"><sup>24</sup></font> possible 
> {@code float} values
> 
> just
> 
> 373      * All 2<sup>24</sup> possible {@code float} values.

I previously made that change and must have inadvertently reverted it. Thanks 
for the catch.

> Also, I think the changes in Scanner would be better of the JLS-style grammar 
> syntax was used, which is what is done in places like java.lang.*. From 
> memory,
> 
> NonTerminal:
>    First Option of the production
>    Second Options of the production

This I interpret to mean the second example in the first block in this section 
http://docs.oracle.com/javase/specs/jls/se7/html/jls-2.html#jls-2.4.

> Offhand, I wasn't aware Dequeue and Queue were maintained in Doug's CVS, but 
> I agree changes to those files should flow through there first.

I shall remove them from the patch.

Thanks,

Brian

Reply via email to