On Sep 20, 2013, at 5:30 PM, Martin Buchholz <marti...@google.com> wrote: > Looks good. > > Random nitpicks: > > I prefer the old variable name DOUBLE_UNIT to DOUBLE_ULP; else you are > inventing a slightly different meaning for ULP. > > I think using hex floating point literals is preferred: > > - private static final double DOUBLE_ULP = 1.0 / (1L << 53); > + private static final double DOUBLE_ULP = 0x1.0p-53; >
I don't have any strong preference on the above comments, Doug? > comment tidy: > > - * Appleby's MurmurHash3 algorithm See > - * http://code.google.com/p/smhasher/wiki/MurmurHash3 . The mix32 > + * Appleby's MurmurHash3 algorithm (see > + * http://code.google.com/p/smhasher/wiki/MurmurHash3). The mix32 > Fine by me. Paul.
