On Oct 16, 2013, at 7:46 PM, Dmitry Nadezhin <dmitry.nadez...@gmail.com> wrote:
> Thank you, Paul.
> I tried to combine your and Joe's suggestions in the updated WebRev:
> http://cr.openjdk.java.net/~bpb/6910473/webrev.2/
> 

Looks good.

A slight concern is that the test sets the max heap size to 8g. Not sure what 
can be done about that. It may cause some execution issues on certain 
environments. Unfortunately i am not sure we have a good way to classify tests 
in terms of resource requirements (beyond scraping the jtreg args) to restrict 
what tests are run in what environments (which i don't think we do), nor i do 
know of a way for the test itself to not bother testing if there will be 
insufficient resources.

Paul.

Reply via email to