On 10/17/13 8:12 PM, Mandy Chung wrote:
Daniel,

Have you considered to revert to the previous version and simply iterate
props.keySet rather than adding a new entry point just for
jdk.internal.util.xml.PropertiesDefaultHandler to use?

Yes - that would be simpler. Here is the new webrev:

http://cr.openjdk.java.net/~dfuchs/webrev_8016344/webrev.01/

-- daniel


Mandy

On 10/17/13 9:18 AM, Daniel Fuchs wrote:
Hi,

Please find below a fix for:

8016344: (props) Properties.storeToXML behaviour has changed from
         JDK 6 to 7

The code for storing properties to XML has changed significantly
between 7 & 8 - but the bug is still present in 8...

This is the fix for JDK 8.

By default Properties.storeToXML uses
sun.util.xml.PlatformXmlPropertiesProvider, and so the test
contains an explicit test for the alternate provider
(jdk.internal.util.xml.PropertiesDefaultHandler) which is only
used on profiles where the default provider is not available.

AFAICT the test should run on all 3 profiles.

<http://cr.openjdk.java.net/~dfuchs/webrev_8016344/webrev.00/>

best regards,

-- daniel


Reply via email to