On 10/18/13 2:08 PM, Alan Bateman wrote:
On 18/10/2013 12:15, Daniel Fuchs wrote:
Yes - that would be simpler. Here is the new webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8016344/webrev.01/
-- daniel
I agree to, this is so much simpler.
Just on the name, TestStoreToXML makes it sound like a general test for
storeToXML but we already have LoadAndStoreXML for that. I just wonder
if the new test should be renamed to something that makes it clearer
what it is testing. Also on the location, maybe we should just move all
the tests for loadFromXML and storeToXML into a xml or some
sub-directory to make it more obvious.
I could remove the storeToXML subdir that I have added and rename the
new test into:
java/util/properties/LoadAndStoreXMLWithDefaults.java
The new test presents some similarities with LoadAndStoreXML, in the
sense that it also stores in a BAOS and reload from a BAIS and
compares the reloaded object with the original - it simply tests
the additional configuration where the saved Properties has a
non null 'defaults' parent.
So naming it LoadAndStoreXMLWithDefaults would make sense, I think.
-- daniel
-Alan
