Hello everybody!
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8024521/3/webrev/
<http://cr.openjdk.java.net/%7Eigerasim/8024521/3/webrev/>
I put the regression test back with some slight modifications.
Now, when run in automatic mode, it uses the default time gap of 2 minutes.
This way it still has a little chance to catch a race.
Additionally I added an instruction about how to run the test with an
arbitrary timing.
Please see the comments in the test.
This should help QA make sure the race is gone.
Sincerely yours,
Ivan
On 18.10.2013 13:16, Alan Bateman wrote:
On 17/10/2013 20:13, Ivan Gerasimov wrote:
Thank you Alan!
Yes, I missed that fact that reading from the recycled file
descriptor is actually a problem by itself.
Would you please take a look at another updated webrev?
It contains another implementation suggested by Paul Sandoz with some
minor changes.
http://cr.openjdk.java.net/~igerasim/8024521/2/webrev/
<http://cr.openjdk.java.net/%7Eigerasim/8024521/2/webrev/>
Here we synchronize close() with calls to available() and read() and
check for asynchronous close() that could have happened in between.
Thanks for the update, this looks much better. Are you planning to
update the comments in processExited, they are a bit of out of date now.
I agree with Martin on the test. Minimally we should ensure that we
have an automated test that exercises this scenario, even if it
doesn't manage to reliably duplicate the issue with an un-patched -JDK.
-Alan
