On 19/10/2013 16:14, Kumar Srinivasan wrote:
Hi Alex,
This looks good.
Hi Sherman, Alan,
Could one of you review this, please
The "-n" options seems okay but I wonder if there has any thought given
to having an option on jarsigner to normalize it before signing?
On the patch itself then I think it needs to be cleaned up before
pushing it. From a quick look:
- It's using a raw type for the packer properties, should be Map<String,
String>
- Is any reason not to use try-with-resources?
- I assume the catching of Exception in createTemporaryFile should be
IOException|SecurityException
- Is the @test tag in the test right?
- The test appears to extract jfr.jar but I don't think we can assume
this exists
- Some of the jar tests use sun.tools.jar.Main and this might be useful here
One other thing, Mathias's mail to jdk8-dev [1] asks for changes that
require translation to be in the master no longer than 10/24. Does the
update to jar.properties count?
-Alan
[1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-October/003443.html
