On 1/9/14 7:38 PM, Mandy Chung wrote:
On 1/9/2014 10:18 AM, Daniel Fuchs wrote:
OK - I removed the unnecessary calls.

http://cr.openjdk.java.net/~dfuchs/webrev_8031068-jdk9/webrev.02/

Thumbs up!  Thanks for the update.

You have fixed a few test failures of this issue. Do you know if there is any other logging test that should be fixed?

Yeah. That's what of the tests that had been identified by Seán in https://bugs.openjdk.java.net/browse/JDK-8029595. Hopefully there's only one left now - though I may have to review my analysis as I did it before discovering that holding the logger in a local variable was not enough to prevent garbage collection...

-- daniel

Mandy


Reply via email to