Hi Stuart,

This looks fine to me.

Tristan: the initialized field is only accessed under synchronization so does not need to be volatile.

Cheers,
David

On 29/01/2014 4:51 PM, Stuart Marks wrote:
Hi all,

Please review this fix to a race condition in rmid initialization.
Briefly, rmid subclasses the RMI registry implementation and provides
special handling for its own stub. Unfortunately the registry is
exported in the super() call, making remote calls possible before rmid's
stub initialization is complete. The fix is to ensure that all remote
calls wait for initialization before proceeding.

Bug:

     https://bugs.openjdk.java.net/browse/JDK-8023541

Webrev:

     http://cr.openjdk.java.net/~smarks/reviews/8023541/webrev.0/

Thanks,

s'marks

Reply via email to