On 30/01/2014 5:34 PM, Tristan Yan wrote:
Hi Stuart
I didn’t make my comment clear. You set interrupted as true when thread
gets interrupted. Here it's still going to wait until systemStub is not
null. Why do you still need interrupt current thread in this case.

Because the golden rule of interrupt handling is you either throw InterruptedException or you re-assert the interrupted state. This allows code further up the stack to respond to interrupts.

David

Thank you
Tristan

On Jan 30, 2014, at 11:24 AM, David Holmes <david.hol...@oracle.com
<mailto:david.hol...@oracle.com>> wrote:

http://cr.openjdk.java.net/~smarks/reviews/8023541/webrev.1/

Reply via email to