Overall it looks ok.

I think you will get some unchecked warnings from
com/sun/org/apache/xerces/internal/xpointer/XPointerHandler.java

Any reason not to address this for your HashMap and ArrayList?

Best
Lance


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad

On Apr 10, 2014, at 7:36 PM, David Li <david.x...@oracle.com> wrote:

> Hi,
> 
> This is an update from Xerces XPointer.  For details, please refer to: 
> https://bugs.openjdk.java.net/browse/JDK-8037259.
> 
> Webrevs: http://cr.openjdk.java.net/~dli/8037259/webrev/
> 
> Existing tests: JAXP SQE and unit tests passed.  No new tests were added 
> because most of the changes are minor and do not add any new functionality.  
> Changes in ElementSchemePointer.java are already covered in JAXP unit test 
> xinclude/Bug6794483Test.java.
> 
> Thanks,
> David

Reply via email to