+1
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 11, 2014, at 7:48 PM, David Li <david.x...@oracle.com> wrote: > Got it, updated. Same place: > http://cr.openjdk.java.net/~dli/8037259/webrev/ > > Thanks, > David > > On 4/11/2014 4:21 PM, Lance Andersen wrote: >> Hi David, >> >> Looks better. You should be able to clean this up further by using the >> diamond operator. Once you do this, you are good to go. >> >> Best >> Lance >> On Apr 11, 2014, at 7:09 PM, David Li <david.x...@oracle.com> wrote: >> >>> Hi Lance, >>> >>> Good catch. I have uploaded a fixed review. I had forgotten about this >>> since Xerces is at JDK 1.4, while we had agreed to move to JDK 1.7. It's >>> good to get these lint warnings fixed now since we are planning to do a >>> large scale fix later on. I also made a similar fix in >>> ElementSchemePointer.java. If you see anything else, then let me know. >>> >>> http://cr.openjdk.java.net/~dli/8037259/webrev/ >>> >>> Thanks, >>> David >>> >>> On 4/11/2014 12:23 PM, Lance @ Oracle wrote: >>>> Overall it looks ok. >>>> >>>> I think you will get some unchecked warnings from >>>> com/sun/org/apache/xerces/internal/xpointer/XPointerHandler.java >>>> >>>> Any reason not to address this for your HashMap and ArrayList? >>>> >>>> Best >>>> Lance >>>> >>>> >>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >>>> Oracle Java Engineering >>>> 1 Network Drive >>>> Burlington, MA 01803 >>>> lance.ander...@oracle.com >>>> Sent from my iPad >>>> >>>> On Apr 10, 2014, at 7:36 PM, David Li <david.x...@oracle.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> This is an update from Xerces XPointer. For details, please refer to: >>>>> https://bugs.openjdk.java.net/browse/JDK-8037259. >>>>> >>>>> Webrevs: http://cr.openjdk.java.net/~dli/8037259/webrev/ >>>>> >>>>> Existing tests: JAXP SQE and unit tests passed. No new tests were added >>>>> because most of the changes are minor and do not add any new >>>>> functionality. Changes in ElementSchemePointer.java are already covered >>>>> in JAXP unit test xinclude/Bug6794483Test.java. >>>>> >>>>> Thanks, >>>>> David >> >> >> <mime-attachment.gif> >> >> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com >
