Hi Michael,
These are functional and unit tests. They reflect what are supported by
the JDK. So yes, you are right, a good portion of them are relevant to
the implementation.
If you are looking for pure JAXP API tests, you'd find them in the JCK.
Thanks,
Joe
On 8/28/2014 12:31 AM, Michael Kay wrote:
I haven't yet had a chance to look at the JAXP tests, but this kind of message suggests
to me that they don't separate what is in JAXP (the interface) from what is in Xalan and
Xerces (the implementations).Would that be a correct assumption? The
"redirect" extension is not a JAXP feature, it is a Xalan feature.
I've had the impression for some years that the management of JAXP as an
interface is far too closely tied up with the management of the JAXP
implementations within the JDK.
Michael Kay
Saxonica
m...@saxonica.com
+44 (0) 118 946 5893
On 28 Aug 2014, at 04:42, Frank Yuan <frank.y...@oracle.com> wrote:
Hi Joe
The test Tristan mentioned that is unable to run with security manager is
http://sqe-hgi.us.oracle.com/hg/index.cgi/testbase/javase/functional/9/xml/file/3f7ae9b99933/src/JAXP/unittests/unit-test/bug6513892
, it is used to test xslt redirect extension. When it runs with security
manager, fails due to;
java.lang.RuntimeException: Use of the extension element 'redirect' is not
allowed when the secure processing feature is set to true.
Anyway, Jibing would communicate with sustaining team about their patch, the
discussion is in another mail chain.
Best Regards
Frank
-----Original Message-----
From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf
Of huizhe wang
Sent: Thursday, August 28, 2014 7:39 AM
To: Tristan Yan
Cc: Core-Libs-Dev
Subject: Re: Review request for JDK-8051540: Convert JAXP functin tests:
org.xml.sax to jtreg (testNG) tests
On 8/27/2014 4:03 PM, Tristan Yan wrote:
Hi Joe and others
I updated the tests with putting them in jaxp repo. I also run these
tests with security manager and they all passed
<http://cr.openjdk.java.net/~tyan/JDK-8051540/webrev01/>
http://cr.openjdk.java.net/~tyan/JDK-8051540/webrev01/
< <http://cr.openjdk.java.net/%7Etyan/JDK-8051540/webrev01/>
http://cr.openjdk.java.net/%7Etyan/JDK-8051540/webrev01/>
Awesome.
Also I’d like to propose our way for handling jaxp tests run with
security manager. The way we’d use is creating two targets for
running jaxp tests. One is for normal run; which will run all the
tests without security manager. One is secure run; the target only run
the tests that have to be run with security manager. This could be
easy to be handled with adding two targets in makefile. And for most
of people they only care about the function. They only need run normal
run target. We would run two targets for any of our formal tests like
nightly, ci build and jprt tests.
Yes, please coordinate with Frank and Eric so that all of the jaxp tests share
the same configuration.
For the tests which can not be run in secure mode(like tests for xsltc
direct extension), we'd add testng group called “secure-hostile”. We
won’t run these tests in secure mode by bypassing them in secure run
target. By this way we could easily transform our tests as usual
without additional effort.
I had been previously updated them so that all of the tests were capable of
running with and without security manager. Sustaining SQE had invested several
month to incorporate the changes into that hosted in Aurora. Please consider
taking the patches from them if you haven't already done so.
Thanks,
Joe
Thank you
Tristan
On Aug 19, 2014, at 10:32 AM, huizhe wang <huizhe.w...@oracle.com
< <mailto:huizhe.w...@oracle.com> mailto:huizhe.w...@oracle.com>> wrote:
By the way, the plan has been that all of the JAXP SQE and Unit tests
be migrated into [openjdk]/jaxp repo under jaxp/test. Tests currently
in the jdk repo shall be moved to jaxp/test as well. I see that your
webrev was generated in jdk9/dev/jdk. I hope it doesn't mean you're
checking tests into the jdk repo.
Thanks,
Joe
On 8/18/2014 4:42 PM, Tristan Yan wrote:
Thanks Joe
We intend to replace the base class with test library because that
doesn’t look like a real base class but an utilities class.
I haven’t tried to run these tests with security manager, I will run
them with security manager then get back you soon.
Thank you.
Tristan
On Aug 18, 2014, at 4:32 PM, huizhe wang <huizhe.w...@oracle.com
< <mailto:huizhe.w...@oracle.com> mailto:huizhe.w...@oracle.com>> wrote:
