I think we’ve agreed that we are not going to attempt to re-introduce the problematic interruptible I/O mechanism. These new methods are targeted at specific use-cases and common patterns found in code. I’d like to do a final review of the spec before finalising it.
http://cr.openjdk.java.net/~chegar/readBytes/webrev.00 -Chris. On 7 May 2015, at 15:10, Chris Hegarty <chris.hega...@oracle.com> wrote: > Thanks for the comments. All have been considered and incorporated ( where > applicable ). > > I sketched out a readAllBytes, added some basic tests, and moved this into a > webrev. I have not created a specdiff, as the changes simply add two new > methods, that are easily readable. > > I think this version, less review comments, covers the most common use-cases. > > http://cr.openjdk.java.net/~chegar/readBytes/webrev.00/ > > -Chris. > > On 5 May 2015, at 10:54, Alan Bateman <alan.bate...@oracle.com> wrote: > >> On 02/05/2015 09:27, Chris Hegarty wrote: >>> : >>> Thanks, this was an editing issue. Removed. >> I think the javadoc looks quite good now, except may be the first statement >> "Reads some bytes ...". It might be clearer to start with "Reads a given >> number of bytes ...". The subsequent text makes the short read case and the >> return value clear. >> >>> >>> As Alan has commented, another readAllBytes() returning a byte[] maybe >>> useful too ( but a different use case ). Let’s park this momentarily, while >>> I sketch up the readAllBytes variant, so we can ensure that the typical use >>> cases have been addressed. Doing so may feedback into the spec of this >>> method. I’ll push this latest draft into the sandbox so it is not lost. >> Yes, a separate use-case but once that I would expect to be common. >> >> -Alan. >> >
