Re: RFR [9] 8133188: docs: replace tags (obsolete in html5) for java.util

[Alexander Stepanov]

Thanks!

Regards,
Alexander

On 8/11/2015 7:10 PM, Martin Buchholz wrote:

Thanks!   Looks good to me.

On Tue, Aug 11, 2015 at 4:33 AM, Alexander Stepanov <alexander.v.stepa...@oracle.com <mailto:alexander.v.stepa...@oracle.com>> wrote:

    Hello Martin,

    the changes were reverted for the following files:

    java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java
    java.base/share/classes/java/util/concurrent/CopyOnWriteArraySet.java
    java.base/share/classes/java/util/AbstractQueue.java
    java.base/share/classes/java/util/Deque.java
    java.base/share/classes/java/util/NavigableMap.java
    java.base/share/classes/java/util/NavigableSet.java

    webrev updated:
    http://cr.openjdk.java.net/~avstepan/8133188/webrev.02
    <http://cr.openjdk.java.net/%7Eavstepan/8133188/webrev.02>

    specdiff report (please update the web page):
    
http://cr.openjdk.java.net/~avstepan/8133188/specdiff.util/overview-summary.html
    
<http://cr.openjdk.java.net/%7Eavstepan/8133188/specdiff.util/overview-summary.html>
    (the changes in concurrent are seemingly due to inherited
    documentation).

    Regards,
    Alexander


    On 8/10/2015 5:28 PM, Martin Buchholz wrote:

    Hi Alexander,

    I've been hoping that someone does cleanups of the jdk as you are
    doing now.

    Some of these source files are part of jsr166 and are maintained
    separately, in jsr166 CVS.
    http://g.oswego.edu/dl/concurrency-interest/
    And that has already been <tt>/<code>-cleaned (although it has
    been done slightly differently) and will be integrated into jdk9
    in an upcoming merge.  So please leave out:
    concurrent/
    *Queue.java
    *Deque.java
    Navigable*.java

    On Mon, Aug 10, 2015 at 6:39 AM, Alexander Stepanov
    <alexander.v.stepa...@oracle.com
    <mailto:alexander.v.stepa...@oracle.com>> wrote:

        Hello,

        Could you please review the following fix:
        http://cr.openjdk.java.net/~avstepan/8133188/webrev.01
        <http://cr.openjdk.java.net/%7Eavstepan/8133188/webrev.01>
        for
        https://bugs.openjdk.java.net/browse/JDK-8133188

        Just a next portion of "<tt>" tags removed.

        specdiff report:
        
http://cr.openjdk.java.net/~avstepan/8133188/specdiff.util/overview-summary.html
        
<http://cr.openjdk.java.net/%7Eavstepan/8133188/specdiff.util/overview-summary.html>
         - some constructs like
        "<tt>(o==null&nbsp;?&nbsp;e==null&nbsp;:&nbsp;o.equals(e))</tt>"
        were replaced with "{@code Objects.equals(o, e)}"
        <mailto:%7B@codeObjects.equals%28o,e%29%7D>
        (e.g.,
        
http://cr.openjdk.java.net/~avstepan/8133188/webrev.01/src/java.base/share/classes/java/util/LinkedList.java.udiff.html
        
<http://cr.openjdk.java.net/%7Eavstepan/8133188/webrev.01/src/java.base/share/classes/java/util/LinkedList.java.udiff.html>);
        - please see JDK-8133188 comments.

        Thanks,
        Alexander