On 01/09/2015 09:38, Vyom Tewari wrote:
Hi everyone,
Can you please review my changes for below bug.
Bug:
JDK-8064470 : JNI exception pending in
jdk/src/java/base/unix/native/libjava/FileDescriptor_md.c
Webrev:
http://cr.openjdk.java.net/~dfuchs/vyom/8064470/webrev.01/
This change ensure that we immediately return if an exception has been
raised (result == NULL) by GetMethodId() or proceed to the next
line if there is no JNI pending exception.
if result is NULL, there is a pending exception, and we return. if
result is not NULL, there is no pending exception, and we proceed to
the next line...
This looks okay although if we run out of resources here then it means
there aren't sufficient resources to even start the VM fully.
The reordering of the includes makes me wonder if jvm.h is needed, it
doesn't appear to be.
-Alan.
