Hi Vyom, On 1 Sep 2015, at 09:38, Vyom Tewari <vyom.tew...@oracle.com> wrote:
> Hi everyone, > > Can you please review my changes for below bug. > > Bug: > JDK-8064470 : JNI exception pending in > jdk/src/java/base/unix/native/libjava/FileDescriptor_md.c > > Webrev: > http://cr.openjdk.java.net/~dfuchs/vyom/8064470/webrev.01/ The changes look ok to me, and consistent with the Windows variant. Note that the final CHECK_NULL is not strictly necessary, but we seem to have adopted this style to avoid potential future mistakes if additional code is added. -Chris. > This change ensure that we immediately return if an exception has been raised > (result == NULL) by GetMethodId() or proceed to the next > line if there is no JNI pending exception. > > if result is NULL, there is a pending exception, and we return. if result is > not NULL, there is no pending exception, and we proceed to the next line... > > Thanks, > Vyom
