On 24/09/15 16:20, Alan Bateman wrote:
On 24/09/2015 14:57, Miroslav Kos wrote:
Hi everybody,
I'd like to ask for review of following fix:
RELAX NG API visible but not accessible
JBS: https://bugs.openjdk.java.net/browse/JDK-8061466
webrev: http://cr.openjdk.java.net/~mkos/8061466/jaxws.01/index.html
- org.relaxng.* classes in jdk.xml.bind module are not repackaged,
but those are not exported so they are not usable outside of module
(jdk) anyway
- processing RelaxNG schemas with JAX-B's declared as
experimental/unsupported, but removing these classes is not easy
since several other packages within JAX-B depend on those ...
This patch repackages these classes from org.relaxng.* to
com.sun.xml.internal.org.relaxng.* + removes loading RelaxNG runtime
in xjc (+ removing related messages).
Good to see these classes being renamed. I agree with Chris that this
should be hg mv so that the history is preserved.
The proposed package name seems okay to me, if only because the
internal classes in this area are already using com.sun.xml.internal.
If this wasn't the case then the jdk or jdk.internal tree would have
been appropriate.
-Alan.
Hi,
I prepared the webrev again with hg move:
http://cr.openjdk.java.net/~mkos/8061466/jaxws.02/index.html
For sure, jprt built again and all tests rerun.
Thanks
Miran
