On 25/09/15 11:46, Alan Bateman wrote:

On 25/09/2015 10:36, Miroslav Kos wrote:
Hi,
I prepared the webrev again with hg move:
http://cr.openjdk.java.net/~mkos/8061466/jaxws.02/index.html

For sure, jprt built again and all tests rerun.
The move and re-packaging looks good to me.

However I see there is more to this as it drops the -relaxng and -relaxng-compat command options so we'll need to make sure that this is tracked (even though these command-line options seems to have always been reported as unsupported and experimental).
If it is necessary, I can file a CCC. Is it? If it is, I suppose it should address just change in tool (xjc) options - the implementation is in jdk.xml.bind, not java.xml.bind

I see the localized versions of the properties have also been changed and re-formatted. At one point then the rule was to not touch localized files because they are generated/changed by translation tools. I don't know know if the master version of these files is in the jaxws repo or maintained somewhere upstream.
The localized properties are in standalone repo, so I suppose it is master(?)

Even if CCC required, it doesn't block us from pushing this, does it? If it was an issue, I can split the changeset into two (repackaging + removing options)

Thanks
Miran

-Alan

Reply via email to