Hi Sherman. Would you please give this another pass? I want make sure all your concerns are met.
Thanks Steve > On Nov 6, 2015, at 12:44 AM, Paul Sandoz <paul.san...@oracle.com> wrote: > > Hi Steve, > > This looks good to me (i only browsed the test code). It’s been around the > block a few times :-) IMO, baring any major issues, it’s time to push and we > can clean up any ancillary issues with later pushes. > > Paul. > >> On 5 Nov 2015, at 18:10, Steve Drach <steve.dr...@oracle.com> wrote: >> >> Hi, >> >> Here’s a new webrev that addresses the issues Paul brought up. The >> versioned entry cache has been removed, the search space has been reduced, >> the documentation for setVersioned(int) and setRuntimeVersioned() has been >> updated to clarify when IllegalStateException is thrown, and the tests have >> been changed to accommodate a jar file with versions 9 and 10, rather than 8 >> and 9. >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-8132734 >> <https://bugs.openjdk.java.net/browse/JDK-8132734> >> JEP 238: https://bugs.openjdk.java.net/browse/JDK-8047305 >> <https://bugs.openjdk.java.net/browse/JDK-8047305> >> Webrev: http://cr.openjdk.java.net/~psandoz/multiversion-jar/jar-webrev/ >> <http://cr.openjdk.java.net/~psandoz/multiversion-jar/jar-webrev/> >> >> Steve >
