Hi Paul,
>> Tests .... don't think we use testng with any hotspot tests so not sure >> about that part. > >There are already quite a few, primarily in the serviceability area, search >for “testng”. We don't use testng for our runtime tests, please change these into normal jtreg tests. Thanks, Christian -----Original Message----- From: hotspot-compiler-dev [mailto:[email protected]] On Behalf Of Paul Sandoz Sent: Friday, November 27, 2015 4:06 AM Cc: hotspot compiler <[email protected]>; Java Core Libs <[email protected]> Subject: Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables > On 27 Nov 2015, at 01:59, David Holmes <[email protected]> wrote: > > Hi Paul, > > On 26/11/2015 7:55 PM, Paul Sandoz wrote: >> Hi, >> >> This is a request for an optimistic review to fork the sun.misc.Unsafe and >> jdk.internal.misc.Unsafe native method tables so that we can evolve the >> latter e.g. for VarHandles unsafe work >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/ >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/ > > Code changes seem fine. > Thanks. > Tests .... don't think we use testng with any hotspot tests so not sure about > that part. There are already quite a few, primarily in the serviceability area, search for “testng”. > Also wondering how these tests will access jdk.internal once we're using the > modular image? > I believe it is sufficient to include: 28 * @modules java.base/jdk.internal.misc or: 28 * @modules java.base/sun.misc We will need to update all tests depending on sun.misc.Unsafe when it moves to a separate module. Paul.
