Never mind. You are right.
The static case is fine with your fix.
There won't be a JNI_OnLoad entry for the dynamic case,
but that entry point is optional.
On 05/25/16 12:44, Naoto Sato wrote:
Attached is the output from "nm -g build/macosx_x64/jdk/lib/libzip.a"
with the proposed fix applied. I see the symbol "_JNI_OnLoad_zip" in
it. Am I missing something?
Naoto
On 5/25/16 9:01 AM, Gary Adams wrote:
This fix will not work for the macosx static build.
e.g. configure --enable-static-build=yes
When linking static libraries the entry point for
JNI_OnLoad_zip is needed to inform the symbol lookups
to be performed on the current executable,
rather than a dynamic library.
On 05/24/16 19:47, Naoto Sato wrote:
Hello,
The previous attempt to fix this one failed in the installer build, as
it does not recognize the added macro. I've updated the fix to add
extra check for static build (yeah, this is redundant with the real
jni_util.h, but effectively avoid the installer build failure).
http://cr.openjdk.java.net/~naoto/8150179/webrev.01/
Please review.
Naoto
