On 7/22/2016 11:57 PM, Alan Bateman wrote:
On 22/07/2016 17:16, Daniel Fuchs wrote:
Hi,
Please find below a fix for
8153082: Update XSTL compiler to generate classes that invoke addReads
https://bugs.openjdk.java.net/browse/JDK-8153082
This fix removes a dependency from java.xml to an internal
java base API.
This looks good. The only thing that looks a bit strange is changing
the class file version during generation. It there any reason not to
bump the default? Separately, we should cache the Configuration as
each translet has the same but that is a separate issue of course.
+1, and +1 for bumping up the default to MAJOR_1_5/MINOR_1_5. The next
then, is that we'll need to consider upgrading BCEL.
-Joe
-Alan
