I don't have any more comments, +1 Stephen
On 25 July 2016 at 07:37, nadeesh tv <nadeesh...@oracle.com> wrote: > Hi Stephen, > > Thanks for the comments. > Please see the updated webrev > http://cr.openjdk.java.net/~ntv/8066806/webrev.11/ > > Changes: Included the suggestions of Stephen > > Thanks and regards, > Nadeesh > > > > On 7/22/2016 3:38 PM, Stephen Colebourne wrote: >> >> These tests are expected to throw exceptions: >> >> test_strict_appendOffsetId() >> test_strict_appendOffset_1() >> test_strict_appendOffset_2() >> test_strict_appendOffset_3() >> test_strict_appendOffset_4() >> >> As such, they should not contain assertEquals(). They should only >> contain the code that is expected to throw (thus they should not have >> .get(OFFSET_SECONDS) either). >> >> test_strict_offset_adjacentInvalidPattern_parse >> test_lenient_offset_adjacentInvalidPattern_parse >> >> should not have .get(OFFSET_SECONDS) >> >> Indentation on line 1621/1622 >> >> thanks >> Stephen >> >> >> On 22 July 2016 at 10:37, nadeesh tv <nadeesh...@oracle.com> wrote: >>> >>> Hi Roger, >>> >>> Thanks for the comments and sorry for the incorrect link. >>> >>> Please see the updated webrev which includes your suggestions. >>> >>> http://cr.openjdk.java.net/~ntv/8066806/webrev.10/ >>> >>> -- >>> Thanks and Regards, >>> Nadeesh TV >>> >>> >>> On 7/21/2016 6:59 PM, Roger Riggs wrote: >>> >>> Hi Nadeesh, >>> >>> Found the changes in http://cr.openjdk.java.net/~ntv/8066806/webrev.09/ >>> >>> Editorial: >>> " >>> >>> In the lenient mode, the parser will be greedy and parse the maximum >>> digits >>> possible." >>> >>> TCKDateTimeFormatterBuilder.java: >>> >>> The lines 1473, 1479, 1485, etc. are way too long, perhaps wrap/break >>> them >>> so each line starts with "." >>> >>> And wrap any other line longer than 100 chars. (Side by side diffs are >>> annoying if the lines are too long). >>> >>> Otherwise, looks good, >>> >>> Thanks, Roger >>> >>> >>> On 7/21/2016 7:21 AM, nadeesh tv wrote: >>> >>> Hi, >>> >>> Please see the updated webrev >>> >>> http://cr.openjdk.java.net/~ntv/8066806/webrev.08/ >>> >>> Changes in this webrev: >>> For leninent mode , doc change in DateTimeFormatterBuilder.java >>> " >>> >>> In the lenient mode, parser will be greedy and parse maximum digits >>> possible. >>> " >>> >>> Added new test cases for lenient mode. >>> >>> >>> >>> -- >>> Thanks and Regards, >>> Nadeesh TV >>> > > -- > Thanks and Regards, > Nadeesh TV >
