> On Sep 16, 2016, at 2:58 AM, Langer, Christoph <christoph.lan...@sap.com> > wrote: > > Hi, > > the fix for https://bugs.openjdk.java.net/browse/JDK-8165524 breaks the AIX > build as function dladdr is not available on AIX. > > There already exist ports of that API in hotspot and awt. With the proposed > change I duplicate the awt port to libjli. This is maybe only a quick fix - > eventually we should think about consolidating and using the hotspot port in > all places by exporting it from libjvm.so for AIX. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8166189 > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8166189.0/
This looks okay. It’d be good to consolidate the hotspot and awt code as a JVM entry point. But launcher would need to carry this copy since dladdr is called before libjvm.so is loaded. formatting nit: not align with lines above (4-space indentation) 55 } 56 return 0; Mandy
