> On Sep 21, 2016, at 8:56 AM, Seán Coffey <sean.cof...@oracle.com> wrote: > > Resurrecting this old review thread. After some internal discussion, I've > dropped the minor edit that was made in StackTraceElementCompositeData. It > could be noisy data for exception purposes. I've corrected the other issues > raised by Alan and Jim has long pushed the changes mentioned below. > > webrev : http://cr.openjdk.java.net/~coffeys/webrev.8151832.v3/webrev/
The change looks okay. src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java 189 throw new IOException("The image file \"" + name + "\" is not " + 190 "the correct version. Major: " + result.getMajorVersion() + 191 ". Minor: " + result.getMinorVersion()); One suggestion for this exception message to: throw new IOException("The image file \"" + name + "\” version “ + result.getMajorVersion() + "." + result.getMinorVersion() + “ not supported”); No need for a new webrev and you can update this before you push. Mandy