Joe - do you mind also checking the list of of qualified exports
declared in java.xml's module-info as I assume that some of these should
be removed as part of this patch (particularly
com.sun.org.apache.xml.internal.resolver and resolver.tools).
-Alan
On 23/09/2016 21:29, Joe Wang wrote:
On 9/23/16, 10:11 AM, Lance Andersen wrote:
Hi Roman,
I made a pass through the webrev and overall, looks OK. Would be
good to have Joe Wang take a look at the Catalog changes as an
additional sanity check.
They look good to me. The dev note in Options.java,
// use Sun's "XML Entity and URI Resolvers" by Norman Walsh
// to resolve external entities.
- // http://www.sun.com/xml/developers/resolver/
+ //
https://xerces.apache.org/xml-commons/components/resolver/resolver-article.html
The whole comment can be changed to:
// use javax.xml.catalog to resolve external entities.
Best,
Joe
I am a bit concerned where we reference jaxb.java.net as in the
package.html given we are not sure where the project will end up
based on the pending changes coming to java.net. For the
specification, I would point to jcp.org vs java.net
I am assuming the standalone TCKs in addition to the JCK are clean
when run against these changes?
HTH
Best
Lance
On Sep 23, 2016, at 6:39 AM, Roman
Grigoriadi<roman.grigori...@oracle.com> wrote:
Hi,
Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
JBS: https://bugs.openjdk.java.net/browse/JDK-8164479
Webrev: http://cr.openjdk.java.net/~aefimov/8164479/00/
You can find change list in the description of JBS and its linked
issues. Most important is removal of code incompatible with JDK9
module system.
With best regards,
Roman
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com<mailto:lance.ander...@oracle.com>
