Hi,

Thank you for review. We were discussing java.net will go down eventually, links to jaxb.java.net is best we have now (to fix submitted javadoc bug), we will update links again when we know new location of standalone projects documentation.

Regarding clean standalone TCK tests - yes they are clean against these changes, but there is one caveat to it: Standalone tests were never run on JDK9 yet. We are trying to utilize a "multirelease-jar" feauture of JDK9 in standalone projects, to avoid using reflection for JDK9 api and checks for module system. This multirelease version of standalone project is still work in progress, tests cannot be run against it yet. We are running standalone TCK tests on JDK8 in separate branch, which has all these changes merged, but lacks JDK9 only compatible classes - namely catalog API and some resource loading with Module#getResourceAsStream. So lets say TCK tests are "almost clean" against this version.

Roman

On 09/26/2016 09:25 AM, Alan Bateman wrote:


On 26/09/2016 00:41, Aleks Efimov wrote:
Hi Alan, Joe, Mandy, Roman,

Suggested changes to the comment section (will bring this change to standalone JAXB) and to the exported internal API were made: com.sun.xml.internal.stream.writers, com.sun.org.apache.xml.internal.resolver, com.sun.org.apache.xml.internal.resolver.tools dependencies were removed.

The updated webrev:
http://cr.openjdk.java.net/~aefimov/8164479/01
Thanks Aleks.

If com.sun.xml.internal.stream.writers is not used directly then I assume the comment "// reflection access ..." can be removed too.

Do we have any issues tracking the issue of direct access to types in com.sun.org.apache.xerces.internal.**. Those will need to be addressed if JAX-WS is to be truely standalone without needing --add-exports options on the command line.

For java.activation then I assume you can run deps too as it should no longer need the `requires java.desktop`. Also I think we can improve the javadoc of CommandInfo.getCommandObject to replace the proposed "If the current runtime environment supports Beans.instantiate ..." to something like "If java.beans.Beans is visible ...".

-Alan


Reply via email to