Nice to see fewer dependencies on internal API!
As you have removed the exports, the related comment can go with it as well:
// reflection access from
com.sun.xml.internal.ws.api.streaming.XMLStreamWriterFactory
- exports com.sun.xml.internal.stream.writers to java.xml.ws;
Best,
Joe
On 9/25/16, 4:41 PM, Aleks Efimov wrote:
Hi Alan, Joe, Mandy, Roman,
Suggested changes to the comment section (will bring this change to
standalone JAXB) and to the exported internal API were made:
com.sun.xml.internal.stream.writers,
com.sun.org.apache.xml.internal.resolver,
com.sun.org.apache.xml.internal.resolver.tools dependencies were removed.
The updated webrev:
http://cr.openjdk.java.net/~aefimov/8164479/01
Best Regards,
Aleksej
On 25/09/16 17:49, Alan Bateman wrote:
On 24/09/2016 18:57, Mandy Chung wrote:
You can run jdeps --check java.xml.ws on your local build with this
change.
This will analyze the dependences and any unused qualified exports.
Good idea. I think java.activation's module-info.java will need
updating too as it no longer requires java.desktop (we can decide at
a later time whether to change this to `requires static` and change
this code to use a reflection guard + static reference).
-Alan
