Hi Daniel,
DocumentBuilderFactory and classes:
- The new methods uses "Creates" instead of "Obtain";
perhaps it should be consistent with existing newInstance methods?
- "Otherwise," and "Otherwise" (with and without ",") are not
consistent in the webrev.
XMLInputFactory.java:
-line 212: the "system-default" should be inside the braces with the
@link.
SchemaFactory.java:
- line 201: (pre-existing typo) "in a implementation" -> "in an
implementation"
XPathFactory.java
- line 177: The {@linkplain platform...} doesn't look like a properly
formed link.
XMLOutputFactoryNewInstanceTest
- line 2, has a 1999 date but is a new file.
Many of the files have long lines (some new) that make side-by-side
compares not fit on the screen.
Regards, Roger
On 11/16/2016 10:24 AM, Daniel Fuchs wrote:
Hi,
Please find below a patch for:
8169778: Add new public methods to get new instances of the
JAXP factories builtin system-default implementations
bug: https://bugs.openjdk.java.net/browse/JDK-8169778
webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8169778/webrev.00/
best regards,
-- daniel
