Hi Joe,
this looks good and contains nice cleanups (some of them I have as well in my
changes for 8169631 :) ).
Some formatting nits:
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java:
line 975 map.put(className+".class", attr);
spaces left and right of '+'
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java
168 private final Map<String,Class<?>>
_loadedExternalExtensionFunctions;
175 TransletClassLoader(ClassLoader parent,Map<String, Class<?>> mapEF)
{
spaces in Map declaration
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java
288 public Map<String,Class<?>> getExternalExtensionsMap() {
spaces
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java
700 LocationArray la = (locations.get(XMLSymbols.EMPTY_STRING));
Braces are unneeded
354 null, null, null, null, JdkXmlUtils.CDATA_CHUNK_SIZE_DEFAULT};
Add 2 more spaces in the beginning and a space before the closing }
Best regards
Christoph
> -----Original Message-----
> From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf
> Of Joe Wang
> Sent: Mittwoch, 16. November 2016 23:13
> To: core-libs-dev@openjdk.java.net
> Subject: RFR (JAXP) 8158619: Very large CDATA section in XML document
> causes OOME
>
> Hi,
>
> Please review an enhancement adding a property to allow for specifying
> the chunk size of CDATA.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8158619
> webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8158619/webrev/
>
> Thanks,
> Joe
