Hi Joe, Overall looks good.
I agree with Daniel that you might want to reconsider reworking JdkXmlUtils.getValue to make it a bit more robust incase of an surprise Object passed for value. HTH Best Lance > On Nov 16, 2016, at 5:12 PM, Joe Wang <huizhe.w...@oracle.com> wrote: > > Hi, > > Please review an enhancement adding a property to allow for specifying the > chunk size of CDATA. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8158619 > webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8158619/webrev/ > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
