Re: RFR: JDK-8172432,jar cleanup/update for module and mrm jar

[Xueming Shen]

Paul,

Thanks for the comments. The webrev has been updated accordingly.

http://cr.openjdk.java.net/~sherman/8172432/webrev

On 1/9/17, 2:21 PM, Paul Sandoz wrote:

At this time of year: usual review comment to update the years in the license.


Main
—

  987                 jentries.stream().forEach( je ->  
addPackageIfNamed(packages, je));

updated.

If you wish you can remove the “.stream()” and go straight to “.forEach(…)” on 
the Set.


1870     private static boolean isModuleInfoEntry(String name) {
1871         // root or versioned module-info.class
1872         return name.endsWith(MODULE_INFO)&&
1873             (name.length() == MODULE_INFO.length() || 
name.startsWith(VERSIONS_DIR));

Is this sufficient? For the versioned case do we need to check it is 
VERSIONS_DIR/{n}/MODULE_INFO ?

updated to verify if the entry has a "n" in between.

Validator
—

   56     private final int vdlen = VERSIONS_DIR.length();

Can be static.

done.

ConcealedPackage
—

Should the class be renamed?

renamed to Basic.java