Thanks Mandy!
webrev has been updated accordingly.
http://cr.openjdk.java.net/~sherman/8172432/webrev/
On 1/9/17, 3:46 PM, Mandy Chung wrote:
This is a good cleanup. This makes it easier to add any further
validation such as JDK-8171830.
Main.java
693 warn("unexpected versioned entry: " + name);
added a jar.properties entry for this.
Should this message be localized?
1870 private static boolean isModuleInfoEntry(String name) {
1871 // root or versioned module-info.class
1872 return name.endsWith(MODULE_INFO)&&
1873 (name.length() == MODULE_INFO.length() ||
name.startsWith(VERSIONS_DIR));
This should return true if it starts with VERSIONS_DIR and the entry
with “/module-info.class"
the method has been updated as Paul suggested, to only take the root
module-info.class
and correct versioned meta-inf/versions/n/module-info.class
Validator.java
314 } catch (Exception x) {}
return "error" now, if there is an exception.
Would it be better to report the error if any exception thrown rather
than silently swallowing it?
