Henry,

You've changed old test cases into new test cases, thereby eliminating the old cases, which is not so good.

You should be adding new test cases, but changing old ones.

-- Jon


On 01/26/2017 02:31 PM, Kumar Srinivasan wrote:

Hi Henry,

Looks ok to me. Thanks for making this change.

Kumar

Hi,

Please review the webrev[1], the fix is to ensure —class-path and —class-path= is processed correctly to expand wildcard. Changes are made in jdk repo. However, test case to verify the bug fix is in langtool repo.

Cheers,
Henry

[1] http://cr.openjdk.java.net/~henryjen/jdk9/8172309/0/
[2] https://bugs.openjdk.java.net/browse/JDK-8172309


Reply via email to