> On May 31, 2017, at 5:06 AM, Roman Grigoriadi <roman.grigori...@oracle.com> > wrote: > > Hi, > > New webrev can be found here: > http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/02/ > <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/02/>
jaxp/src/java.xml/share/classes/module-info.java I’m happy to see this qualified exports removed. Can you update jdk/test/jdk/modules/etc/JdkQualifiedExportTest.java to remove "java.xml/com.sun.xml.internal.stream.writers” from KNOWN_EXCEPTION. java.xml.ws/share/classes/com/sun/xml/internal/ws/api/streaming/XMLStreamReaderFactory.java java.xml.ws/share/classes/com/sun/xml/internal/ws/api/streaming/XMLStreamWriterFactory.java jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/ws/util/MrJarUtil.java MrJarUtil::getNoPoolProperty is not MR specific. Are you trying to keep the different default value when building for older release? It would be clearer if you want to define a constant for the default value that is subject to the runtime version. XMLStreamReaderFactory and XMLStreamWriterFactory would get the property value with the MR-specific default. That’re the files I reviewed. Mandy
