Hi all,
Additional minor comments on top of what others already provided
MimetypesFileTypeMap.java
- Are the Parens around lines 54-57 really needed?
- defaultType and confDir, shouldn’t these be all caps like PROG?
- For the doPrivileged method, not sure the minimum JDK version you
want to be compatible with, but you could use a lambda or specify the specific
permission
ModuleUtil.java
- The BufferedReader I would take advantage of try with resources so
you do not have to specify finally
> On Mar 12, 2017, at 10:39 AM, Roman Grigoriadi <[email protected]>
> wrote:
>
> Hi,
>
> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8176508
> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/00/
>
> Summary of changes:
>
> jaxws/src/java.activation/share/classes/javax/activation/*
> These are from Bill, fixing JDK-8049379
>
> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
> JDK-8169496 - JAXB annotated classes needs to be open for JAXB impl module.
> Javadoc updates + propagation of openness if JAXB impl is in other module
> than java.xml.bind. This needs an update to JAXB JCK tests.
>
> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
> Contains a fix for reported bug after removal dependencies to JDK internal
> classes from SAAJ + formattig updates according to review comments on last
> sync.
>
> jaxws/src/java.xml.ws/share/classes/**/*Messages.java
> jaxws/src/jdk.xml.ws/share/classes/**/*Messages.java
> These are generated files, which were modified manually in JDK in order to
> solve JDK-8153944. Generation of these file was updated (removed Lambda),
> these changes should respect JDK-8153944 fix.
>
> Patch also contains several small bugfixes, not tracked in JBS.
>
> Best regards,
> Roman
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
