A few more updates as there was a bit more crud to address. The webrev is at:
http://cr.openjdk.java.net/~lancea/8181832/webrev.00/ <http://cr.openjdk.java.net/~lancea/8181832/webrev.00/> Best Lance > On Jun 9, 2017, at 9:38 AM, Lance Andersen <lance.ander...@oracle.com> wrote: > >> >> On Jun 9, 2017, at 9:26 AM, Alan Bateman <alan.bate...@oracle.com> wrote: >> >> >> >> On 09/06/2017 14:15, Lance Andersen wrote: >>> Hi all, >>> >>> This patches addresses the broken link reported in JDK-8181832 >>> >>> ———— >>> $ hg diff >>> diff -r 67ad6b89dd96 >>> src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html >>> --- a/src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html >>> Wed Jun 07 15:05:35 2017 -0400 >>> +++ b/src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html >>> Fri Jun 09 09:13:49 2017 -0400 >>> @@ -119,7 +119,7 @@ >>> techniques for maintaining the integrity of data. However, specific >>> standards >>> groups have considered offering XML-based synchronization. For details, see >>> <PRE> >>> - <a href="http://www.syncml.org">http://www.syncml.org</a> >>> + <a >>> href="http://www.openmobilealliance.org/wp/Affiliates/SyncML.html">http://www.openmobilealliance.org/wp/Affiliates/SyncML.html</a> >>> </PRE> >>> >> Would it be better to drop this paragraph and link completely? >> >> I also wonder if the paragraphs about the RI should move into their own >> section so that it is clear that they are implementation specific - users of >> this API can't assume the two providers discussed are present. > > I think for 9, I would prefer to just address the broken link and look to > revisit for 10. This has been documented this way since JDK 5, so I think if > I am going to make changes, I would like to spend some more time thinking > about it. > > Is that acceptable? > > Best > Lance >> >> -Alan > > <http://oracle.com/us/design/oracle-email-sig-198324.gif > <http://oracle.com/us/design/oracle-email-sig-198324.gif>> > <http://oracle.com/us/design/oracle-email-sig-198324.gif > <http://oracle.com/us/design/oracle-email-sig-198324.gif>> > <http://oracle.com/us/design/oracle-email-sig-198324.gif > <http://oracle.com/us/design/oracle-email-sig-198324.gif>> > <http://oracle.com/us/design/oracle-email-sig-198324.gif > <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> > <mailto:lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>