Re: (10/jaxp) RFR of JDK-8184062: wrong @modules javax.xml at jaxp/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java

[Amy Lu]

I noticed the module dependency is declared at 
test/javax/xml/jaxp/unittest/TEST.properties
So @modules in this test file can just be deleted.

Moreover, just noticed there are two @test which should be cleaned up.
( Not a reviewer.)

Thanks,
Amy

On 7/10/17 5:17 PM, Hamlin Li wrote:
Would you please review below patch?

bug: https://bugs.openjdk.java.net/browse/JDK-8184062

webrev: http://cr.openjdk.java.net/~mli/8184062/webrev.00/, also 
attach diff as below


Thank you

-Hamlin

------------------------------------------------------------------------
diff -r 18b09cba334b 
test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java
--- 
a/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java 
 Fri Jul 07 03:13:49 2017 +0000
+++ 
b/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java 
 Mon Jul 10 02:13:39 2017 -0700
@@ -45,7 +45,7 @@
 /*
  * @test
  * @bug 8145974
- * @modules javax.xml
+ * @modules java.xml
  * @test
  * @library /javax/xml/jaxp/libs /javax/xml/jaxp/unittest
  * @run testng/othervm -DrunSecMngr=true 
stream.XMLStreamWriterTest.SurrogatesTest