Hi Lance, Amy,
As you suggested, deleted @modules and redundant @test in
SurrogatesTest.java, the change is pushed.
Thank you
-Hamlin
On 2017/7/10 20:20, Lance Andersen wrote:
Hi Hamilin
On Jul 10, 2017, at 5:59 AM, Amy Lu <amy...@oracle.com
<mailto:amy...@oracle.com>> wrote:
I noticed the module dependency is declared at
test/javax/xml/jaxp/unittest/TEST.properties
So @modules in this test file can just be deleted.
Agree and on a quick scan this is the only test in that directory
which includes @modules
Moreover, just noticed there are two @test which should be cleaned up.
+1
( Not a reviewer.)
Thanks,
Amy
On 7/10/17 5:17 PM, Hamlin Li wrote:
Would you please review below patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8184062
webrev: http://cr.openjdk.java.net/~mli/8184062/webrev.00/
<http://cr.openjdk.java.net/%7Emli/8184062/webrev.00/>, also attach
diff as below
Thank you
-Hamlin
------------------------------------------------------------------------
diff -r 18b09cba334b
test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java
---
a/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java
Fri Jul 07 03:13:49 2017 +0000
+++
b/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java
Mon Jul 10 02:13:39 2017 -0700
@@ -45,7 +45,7 @@
/*
* @test
* @bug 8145974
- * @modules javax.xml
+ * @modules java.xml
* @test
* @library /javax/xml/jaxp/libs /javax/xml/jaxp/unittest
* @run testng/othervm -DrunSecMngr=true
stream.XMLStreamWriterTest.SurrogatesTest
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
