Hello,

I'm wary of increasing the timeout to 5 minutes. When such tests are run on CI servers, the effective timeout can be 10 minutes or more given a timeout factor used for the test run.

Should using 1GB of memory on the @run line have an earlier @requires guard for an amount of memory on the system?

Cheers,

-Joe

On 1/22/2018 12:58 PM, Andrey Nazarov wrote:
Hi,
please review Jlink tests.

I’ve increased default timeout to 5 minutes and skip tests in “-Xcomp” VM mode.

CR: http://cr.openjdk.java.net/~anazarov/JDK-8161348/webrev.00/ 
<http://cr.openjdk.java.net/~anazarov/JDK-8161348/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8161348 
<https://bugs.openjdk.java.net/browse/JDK-8161348>

—Andrei

Reply via email to