> On Feb 8, 2018, at 3:04 AM, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 07/02/2018 16:57, Lance Andersen wrote:
>> Hi all,
>> I think we are at a point where we are ready to start reviewing  the changes 
>> to remove the Java EE and CORBA modules as JEP 320, JDK-8189188,  has been  
>> targeted to JDK 11.
>> The CSR for removing the modules has been approved: 
>> https://bugs.openjdk.java.net/browse/JDK-8193757 
>> <https://bugs.openjdk.java.net/browse/JDK-8193757>
>>  The open webrev can be found at:  
>> http://cr.openjdk.java.net/~lancea/8190378/open_changes/ 
>> <http://cr.openjdk.java.net/~lancea/8190378/open_changes/>
> 800 KLOC deleted, wonderful!
> The update to technology-summary.html page means its html title no longer 
> matches the contents. We should probably change it to "JCP Technologies in 
> JDK 11" for now.

I updated the webrev. Thanks for catching that (btw we missed this for JDK 10)
> The removal of test cases from the tests in tools/launcher/modules removes 
> most of the test coverage for the upgrade module path. We'll need to replace 
> these sub-tests. Can you create an issue to track that?

I can do that 
> Everything else looks good and it's okay to track residual issues with other 
> JIRA issues. I think the important thing is to get this monster patch into 
> JDK builds soon so that libraries and the eco system can start to adjust.

Thank you Alan for the review

> -Alan

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Reply via email to