Hi David, I thought I did make that change. Let me go back and double check and if not, will push. My build worked fine but maybe I missed this in a merge.
Best Lance > On Feb 13, 2018, at 8:05 AM, David Holmes <david.hol...@oracle.com> wrote: > > Lance, > > In Docs.gmk you seem to have missed this: > > 445 > ################################################################################ > 446 # Setup generation of the Java SE API documentation (javadoc + > modulegraph) > 447 > 448 # The Java SE module scope is just java.se.ee and its transitive indirect > 449 # exports. > 450 JAVASE_MODULES := java.se.ee > 451 > 452 $(eval $(call SetupApiDocsGeneration, JAVASE_API, \ > 453 MODULES := $(JAVASE_MODULES), \ > 454 SHORT_NAME := $(JAVASE_SHORT_NAME), \ > 455 LONG_NAME := $(JAVASE_LONG_NAME), \ > 456 TARGET_DIR := $(IMAGES_OUTPUTDIR)/javase-docs/api, \ > 457 )) > > which now results in a doc build hanging due to the non-existent java.se.ee > module. It leads to execution of: > > grep -e @moduleGraph > > with no module-info.java argument, which causes grep to hang trying to read > from stdin. > > At least that is what my analysis indicates. I simply set: > > JAVASE_MODULES := > > to work around it. > > David > ----- > > On 8/02/2018 11:37 PM, Lance Andersen wrote: >>> On Feb 8, 2018, at 3:04 AM, Alan Bateman <alan.bate...@oracle.com> wrote: >>> >>> On 07/02/2018 16:57, Lance Andersen wrote: >>>> Hi all, >>>> >>>> I think we are at a point where we are ready to start reviewing the >>>> changes to remove the Java EE and CORBA modules as JEP 320, JDK-8189188, >>>> has been targeted to JDK 11. >>>> The CSR for removing the modules has been approved: >>>> https://bugs.openjdk.java.net/browse/JDK-8193757 >>>> <https://bugs.openjdk.java.net/browse/JDK-8193757> >>>> >>>> The open webrev can be found at: >>>> http://cr.openjdk.java.net/~lancea/8190378/open_changes/ >>>> <http://cr.openjdk.java.net/~lancea/8190378/open_changes/> >>>> >>> 800 KLOC deleted, wonderful! >>> >>> The update to technology-summary.html page means its html title no longer >>> matches the contents. We should probably change it to "JCP Technologies in >>> JDK 11" for now. >> I updated the webrev. Thanks for catching that (btw we missed this for JDK >> 10) >>> >>> The removal of test cases from the tests in tools/launcher/modules removes >>> most of the test coverage for the upgrade module path. We'll need to >>> replace these sub-tests. Can you create an issue to track that? >> I can do that >>> >>> Everything else looks good and it's okay to track residual issues with >>> other JIRA issues. I think the important thing is to get this monster patch >>> into JDK builds soon so that libraries and the eco system can start to >>> adjust. >> Thank you Alan for the review >> Best >> Lance >>> >>> -Alan >> <http://oracle.com/us/design/oracle-email-sig-198324.gif >> <http://oracle.com/us/design/oracle-email-sig-198324.gif>> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif >> <http://oracle.com/us/design/oracle-email-sig-198324.gif>> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif >> <http://oracle.com/us/design/oracle-email-sig-198324.gif>> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif >> <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| >> Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> >> <mailto:lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
