On 29/03/2018 13:18, David Lloyd wrote:
:
OK great. In that case, I think all feedback has been accounted for,
and this should be ready to go AFAIK.
I skimmed through the patch attached to your last mail. I also saw
Sherman's mail offering to look at the existing wording about the flush
marker. So I think this the API is good and we should get the CSR submitted.
I'm less sure about the tests. The patch modifies FlaterTest but it's
not clear that is covers all the scenarios, ReadOnlyBufferException just
one that comes to mind. Maybe we could identify additional tests while
the CSR is in progress.
-Alan
