On 12/04/2018 18:38, Alexander Miloslavskiy wrote:
I still need someone to get this patch applied. Please?

At this moment, it seems that patch is validated:

> Martin Buchholz
> But regardless of that, we should try to set the CLOEXEC bit on all
> our file descriptor

> Alan Bateman
> The update to osSupport_Windows.cpp looks okay.

I'm happy to take the Windows change and get that in.

I'm still puzzled by the Unix change. I completely agree with Martin about CLOSEXEC but there is something fishy here that we need to get a handle on. When we fork then we close >= 3 in the child so there shouldn't be any magic with fd 3.

-Alan

Reply via email to