Re: RFR (JDK11/NIO) 8201276: (fs) Add methods to Files for reading/writing a string from/to a file

[Joe Wang]

Hi Hamlin,

Thanks for reviewing the test! Fixed now, by calling deleteOnExit. 
Indeed, I didn't realize I got a few empty tmp files :-)

Best,
Joe

On 4/28/2018 12:35 AM, Hamlin Li wrote:
Hi Joe,

just a minor comment about the test in ReadWriteString.java.

For both testMalformedWrite and testMalformedRead, temp files are not 
deleted, as Files.deleteIfExists(path); is skipped by the expected 
IOException. File.deleteOnExit​() may help.

Thank you

-Hamlin


On 27/04/2018 12:50 PM, Joe Wang wrote:
Hi,

We're looking into adding methods to Files to read a file into a 
String/write a String to a file. Below is the current proposal. 
Please review.

JBS: https://bugs.openjdk.java.net/browse/JDK-8201276

webrev: http://cr.openjdk.java.net/~joehw/jdk11/8201276/webrev/

specdiff: 
http://cr.openjdk.java.net/~joehw/jdk11/8201276/specdiff/java/nio/file/Files.html


Thanks,
Joe