Hi Bob,
On 5/30/18 12:45 PM, Bob Vandette wrote:>
RFE: Container Metrics
https://bugs.openjdk.java.net/browse/JDK-8203357
WEBREV:
http://cr.openjdk.java.net/~bobv/8203357/webrev.00
Looks fine in general. It's good to have this internal API ready
for JFR and other library code to use.
I skimmed through the new tests. It'd be good to add some comments
to describe what it does (for example, set up a docker image etc).
launcher.properties
154 \ -XshowSettings:system (Linux Only) show host system or
container\n\
155 \ configuration and continue\n\
A newline can be placed after -XshowSettings:system consistent with
other suboptions.
test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java
There are several long lines in the new test files such as:
MetricsCpuTester.java
MetricsMemoryTester.java
MetricsTester.java
It'd help future side-by-side review if they are wrapped. I think
most of them are the construction of an exception.
I see a pattern of a name after @test and that is not strictly needed.
TestCgroupMetrics.java
25 * @test TestCgroupMetrics
TestDockerCpuMetrics.java
34 * @test TestSystemMetrics
TestDockerMemoryMetrics.java
30 * @test TestSystemMetrics
TestSystemMetrics.java
25 * @test TestSystemMetrics
This needs a CSR for the new -XshowSettings:system option.
Mandy
